Londonl May-2025lping wanglCoursework/sprint 1 #641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kodnificent
added
Review in progress
kodnificent
suggested changes
Jul 14, 2025
Comment on lines
+15
to
+18
| const last4Digits = cardNumber.toString.slice(-4); | ||
|
|
||
| //then conver to number | ||
| const last4Digits = Number(cardNumber.toString.slice(-4)); |
There was a problem hiding this comment.
Defining last4Digits as a constant twice will fail
| // The right coe should be: | ||
|
|
||
| const TwelveHourClockTime = "8:53" |
There was a problem hiding this comment.
Instead of "8:53", you can do "08:53". Its good practice to always pad 12-hour formats with a zero to the left
kodnificent
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self checklist
After i did study prep for sprint 1 and also spent nearly two weeks for whole python, i started to do coursework and sometimes i did use chatgpt help me if i stuck with questions
Ask any questions you have for your reviewer.